thecodingmachine / phpstan-strict-rules
A set of additional rules for PHPStan based on best practices followed at TheCodingMachine
Installs: 5 498 259
Dependents: 250
Suggesters: 2
Security: 0
Stars: 281
Watchers: 19
Forks: 21
Open Issues: 12
Type:phpstan-extension
Requires
- php: ^7.1|^8.0
- phpstan/phpstan: ^1.0
Requires (Dev)
- php-coveralls/php-coveralls: ^2.1
- phpunit/phpunit: ^7.1
This package is auto-updated.
Last update: 2024-12-10 14:37:23 UTC
README
TheCodingMachine's additional rules for PHPStan
This package contains a set of rules to be added to the wonderful PHPStan static analyzer.
Those rules come from TheCodingMachine best practices. They are more "strict" than the default PHPStan rules and some may be controversial. We use those at TheCodingMachine, have found them to help us in our daily work, and ask anyone working with us to follow them.
Rules list
Exception related rules
- You should not throw the "Exception" base class directly but throw a sub-class instead.
- You should not have empty catch statements
- When throwing an exception inside a catch block, you should pass the catched exception as the "previous" exception
- If you catch a
Throwable
, anException
or aRuntimeException
, you must rethrow the exception.
Superglobal related rules
- The use of
$_GET
,$_POST
,$_FILES
,$_COOKIE
,$_SESSION
,$_REQUEST
is forbidden. You should instead use your framework's request/session object. - Superglobal usage is still tolerated at the root scope (because it is typically used once in
index.php
to initialize PSR-7 request object)
Condition related rules
- Switch statements should always check for unexpected values by implementing a default case (and throwing an exception)
Work-in-progress
// Never use public properties
// Never use globals
Installation
We assume that PHPStan is already installed in your project.
To use this extension, require it in Composer:
composer require --dev thecodingmachine/phpstan-strict-rules
If you also install phpstan/extension-installer then you're all set!
Manual installation
If you don't want to use phpstan/extension-installer
, include phpstan-strict-rules.neon in your project's PHPStan config:
includes: - vendor/thecodingmachine/phpstan-strict-rules/phpstan-strict-rules.neon